Implementation of new SparsityOp #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdamme
approved these changes
Aug 5, 2024
There was a problem hiding this comment.
Thanks for this contribution, @Garic152. The sparsity built-in/op will be useful for testing sparsity estimation for now (maybe we find a better solution in the future, but I think this approach is quite straightforward). Your code looks very good to me. I only applied some minor changes (see my commit). This PR is ready to be merged.
|
All tests pass successfully on my machine and did pass in the CI before my mostly syntactical changes. At the moment, the CI fails due to problems in setting up the container. Thus, I think it's safe to merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
SparsityOpthat allows users to print the compile-time sparsity estimate of a matrix to the screen. The function can be called usingsparsity(Matrix), which will be replaced with the sparsity value through canonicalization if the sparsity is known. If the sparsity is unknown, it will return -1.This PR does not yet include tests. The SparsityOp functionality will be tested as part of #766.